On Wed, May 27, 2015 at 02:23:22PM -0700, Sukadev Bhattiprolu wrote:
> At run time, (i.e when perf is starting up), locate the specific events
> table for the current CPU and create event aliases for each of the events.
> 
> Use these aliases to parse user's specified perf event.
> 
> Signed-off-by: Sukadev Bhattiprolu <suka...@linux.vnet.ibm.com>

please prefix the subject with 'perf tools'

SNIP

> +/*
> + * From the pmu_events_map, find the table of PMU events that corresponds
> + * to the current running CPU. Then, add all PMU events from that table
> + * as aliases.
> + */
> +static int pmu_add_cpu_aliases(void *data)
> +{
> +     struct list_head *head = (struct list_head *)data;
> +     int i;
> +     struct pmu_events_map *map;
> +     struct pmu_event *pe;
> +     char *cpuid;
> +
> +     cpuid = get_cpuid_str();
> +     if (!cpuid)
> +             return 0;
> +
> +     i = 0;
> +     while (1) {
> +             map = &pmu_events_map[i++];
> +             if (!map->table)
> +                     return 0;

leaking cpuid

> +
> +             if (!strcmp(map->cpuid, cpuid))
> +                     break;
> +     }
> +
> +     /*
> +      * Found a matching PMU events table. Create aliases
> +      */
> +     i = 0;
> +     while (1) {
> +             pe = &map->table[i++];
> +             if (!pe->name)
> +                     break;
> +
> +             /* need type casts to override 'const' */
> +             __perf_pmu__new_alias(head, (char *)pe->name, NULL,
> +                             (char *)pe->desc, (char *)pe->event);
> +     }
> +
> +     free(cpuid);
> +
> +     return 0;
> +}

SNIP
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to