On Thu, May 22, 2008 at 4:40 PM, Emil Medve <[EMAIL PROTECTED]> wrote: > This will cause this minor boot-time debugging error message to go away: > > [ 1.316451] calling add_pcspkr+0x0/0x84 > [ 1.316478] initcall add_pcspkr+0x0/0x84 returned -19 after 0 msecs
What situation are you hitting this in? The code should only run if there is a "pnpPNP,100" compatible node in the device tree. Also, where is CONFIG_PCSPKR_PLATFORM defined? I don't see it anywhere in powerpc code and only a reference to it in an x86 Makefile. As it stands, it looks like this patch unconditionally disables the pcspkr code. Cheers, g. > > Signed-off-by: Emil Medve <[EMAIL PROTECTED]> > --- > >> scripts/checkpatch.pl >> 0001--POWERPC-Add-the-PC-speaker-only-when-requested-so.patch > total: 0 errors, 0 warnings, 14 lines checked > > 0001--POWERPC-Add-the-PC-speaker-only-when-requested-so.patch has no obvious > style problems and is ready for submission. > > arch/powerpc/kernel/setup-common.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/kernel/setup-common.c > b/arch/powerpc/kernel/setup-common.c > index db540ea..61a3f41 100644 > --- a/arch/powerpc/kernel/setup-common.c > +++ b/arch/powerpc/kernel/setup-common.c > @@ -500,6 +500,7 @@ void __init smp_setup_cpu_sibling_map(void) > } > #endif /* CONFIG_SMP */ > > +#ifdef CONFIG_PCSPKR_PLATFORM > static __init int add_pcspkr(void) > { > struct device_node *np; > @@ -522,6 +523,7 @@ static __init int add_pcspkr(void) > return ret; > } > device_initcall(add_pcspkr); > +#endif /* CONFIG_PCSPKR_PLATFORM */ > > void probe_machine(void) > { > -- > 1.5.5.GIT > > _______________________________________________ > Linuxppc-dev mailing list > [EMAIL PROTECTED] > https://ozlabs.org/mailman/listinfo/linuxppc-dev > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-embedded mailing list Linuxppc-embedded@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-embedded