On May 22, 2008, at 6:27 PM, Grant Likely wrote:

On Thu, May 22, 2008 at 4:40 PM, Emil Medve <[EMAIL PROTECTED] > wrote:
This will cause this minor boot-time debugging error message to go away:

[    1.316451] calling  add_pcspkr+0x0/0x84
[ 1.316478] initcall add_pcspkr+0x0/0x84 returned -19 after 0 msecs

What situation are you hitting this in?  The code should only run if
there is a "pnpPNP,100" compatible node in the device tree.

The code always runs, the -19 is from the fact that the code returns - ENODEV when it doesn't find the device in the tree.

I don't see any reason we should be ALWAYS be probing for a PC speaker. Seems like a reasonable patch.

Also, where is CONFIG_PCSPKR_PLATFORM defined?  I don't see it
anywhere in powerpc code and only a reference to it in an x86
Makefile.  As it stands, it looks like this patch unconditionally
disables the pcspkr code.

Its defined in init/Kconfig.


- k
_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded

Reply via email to