On Fri, May 02, 2014 at 12:37:51PM +0200, Jiri Benc wrote:
> Split management message creation to more fine-grained functions to allow
> notification messages to be created.

I must admit I didn't understand what you did, at first reading. Can
you lose a few words about how you split the code and why?

Is it that the 'fill' method is shared by regular management replies
and by the event notifiers?

...

> +struct ptp_message *port_management_reply(struct PortIdentity pid,
> +                                       struct port *ingress,
> +                                       struct ptp_message *req)
> +{
> +     UInteger8 boundaryHops;
> +
> +     boundaryHops = req->management.startingBoundaryHops - 
> req->management.boundaryHops;

Line too long.

Thanks,
Richard

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to