Hi Richard,

This series looks excellent with a few minor questions.

> -----Original Message-----
> From: Richard Cochran [mailto:richardcoch...@gmail.com]
> Sent: Sunday, August 16, 2015 1:15 PM
> To: linuxptp-devel@lists.sourceforge.net
> Subject: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration
> implementation
> 
> Changes in V3:
> - Reduced interface to two types, double and int
>   (enums are accessed like ints)
> - Converted almost everything
> 

You converted the PI options, but I can't figure exactly how they were read. 
There doesn't appear to be any calls to "config_get_int" or config_get_dbl for 
them in their respective patches.

The only other interesting one was the options which took ASAP as a value. That 
definitely seemed a little hack, but it seems ok to support that option. I 
don't expect most options to need that sort of work-around.

Regards,
Jake


------------------------------------------------------------------------------
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to