> -----Original Message----- > From: Keller, Jacob E [mailto:jacob.e.kel...@intel.com] > Sent: Monday, August 17, 2015 1:54 AM > To: Richard Cochran > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration > implementation > > > -----Original Message----- > > From: Richard Cochran [mailto:richardcoch...@gmail.com] > > > > You are right, Jake. I forgot the config_get_dbl() calls. It is hard > > to express how mind numbing this conversion work is. On top of that, > > I must have rebased this series dozens of times, in order to refine > > the API. :S > > > > Did you check all of the other conversions, or did you give up? > > > > Thanks for the careful review, > > > > Richard > > I didn't notice any others missing, but I can't exactly say how carefully I > checked. I think all of the PI options were missed, but nothing else appeared > to be missing. Glad to catch this early. I can go take a quick look at the > final > result you posted on github for any issues. > > Regards, > Jake >
With some clever use of ack and sed, I did a search for all uses of config_(double|int)_ that grabbed the various options. The only ones missing are: "pi_integral_exponent" "pi_integral_norm_max" "pi_integral_scale" "pi_proportional_exponent" "pi_proportional_norm_max" Hope this helps. Regards, Jake ------------------------------------------------------------------------------ _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
