> -----Original Message----- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Friday, November 04, 2016 11:02 AM > To: Miroslav Lichvar <mlich...@redhat.com> > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH RFC 1/3] Add options to prefix ptp4l and > phc2sys log messages. > > On Fri, Nov 04, 2016 at 03:31:18PM +0100, Miroslav Lichvar wrote: > > Ok, so the option should be called print-tag, log-tag, message-tag, or > > something else? > > 'message_tag' seems best to me. >
I think you could still consider it a (as in one of many) prefix, as both of the things you said that appear before it may also be considered prefix. I don't mind the name "message_tag", though. > > I wouldn't mind if phc2sys and pmc supported config files, but I think > > this particular option might be one of those that make more sense to > > be used on command line rather than config file. If I wanted to run > > multiple ptp4l instances with different tags for their log messages, > > I could still share the config file between them if I specified the > > interface and tag on the command line. > > Ok, that is a reason. But please can we have '-t' instead of '-o'? > > -o makes me think of "output file". > Agreed, -t is better. > > Would it be less confusing if we introduced GNU-style long option > > names? > > Not to me. PTP has tons of options, and every new profile forces more > and more of these. I simply find it gross when programs have a > gazillion command line options. It makes for poor usability. I > really wanted ptp4l to have the "top ten" options available on the > command line, in order to keep it simple for the most common use > cases. > I think in this case introducing a "long" option would make more sense than using more small options. I do agree that we shouldn't proliferate command line options for every single thing in the config, (as many of these are esoteric and we would have to add more and more options as time goes on). However, I think that using long options can provide clarity that a small 1letter option name doesn't. That being said, "-t" makes sense to me. > I think we should consider the long options for v2 if people really > want them... > > Thanks, > Richard > Thanks, Jake ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
