> -----Original Message----- > From: Richard Cochran [mailto:[email protected]] > Sent: Friday, August 18, 2017 2:00 PM > To: [email protected] > Subject: [Linuxptp-devel] [PATCH RFC 00/11] ITU G.8275 Telecom Profile > > This series implements the SECOND telecom profile, > > ITU-T G.8275.1/Y.1369.1 > > Precision time protocol telecom profile for phase/time > synchronization with full timing support from the network > > not to be confused with the FIRST telecom profile: > > ITU-T G.8265.1/Y.1365.1 > > Precision time protocol telecom profile for frequency > synchronization >
This has me curious what's in the first telecom profile.... > Comments and review are most welcome. > > Thanks, > Richard > I like the overall method, and functionalizing the comparison algorithm is pretty straight forward. I only had one comment regarding the portDS and defaultDS, which I assume refer to "Domain Specific"? Would it make sense to subclass this into .telecom. so it's more obvious this is very specific to the telecom profile? Besides this I didn't see any obvious things, though I would warn I have not read the telecom comparison spec in detail so I could not verify that the algorithm you provided is identical or not Thanks, Jake > > Richard Cochran (11): > port: Make the data set comparison algorithm into a function variable. > clock: Make the data set comparison algorithm into a function > variable. > bmc: Allow alternative data set comparison algorithms. > bmc: Make the second part of the data set comparison algorithm public. > telecom: Introduce the local priority into the data set. > telecom: Add the data set comparison algorithm from the Telecom > Profile. > telecom: Add a configuration option for defaultDS.localPriority. > telecom: Add a configuration option for portDS.localPriority. > telecom: Add a configuration option to use the alternate BMCA. > telecom: Introduce the "notSlave" option. > telecom: Add a default configuration for the Telecom Profile. > > bmc.c | 16 ++++------- > bmc.h | 34 ++++++++++++++++++++-- > clock.c | 12 ++++++-- > config.c | 12 ++++++++ > default.cfg | 4 +++ > ds.h | 1 + > gPTP.cfg | 4 +++ > makefile | 2 +- > port.c | 16 ++++++++++- > ptp4l.8 | 36 ++++++++++++++++++++++++ > telecom.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++ > telecom.cfg | 93 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 12 files changed, 287 insertions(+), 16 deletions(-) > create mode 100644 telecom.c > create mode 100644 telecom.cfg > > -- > 2.11.0 > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Linuxptp-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linuxptp-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
