> -----Original Message----- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Friday, August 18, 2017 10:57 PM > To: Keller, Jacob E <jacob.e.kel...@intel.com> > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH RFC 00/11] ITU G.8275 Telecom Profile > > On Sat, Aug 19, 2017 at 12:31:40AM +0000, Keller, Jacob E wrote: > > This has me curious what's in the first telecom profile....
> FWIW, both profiles are publicly available documents. Yea, I went and googled the documents after writing this. > > > I like the overall method, and functionalizing the comparison > > algorithm is pretty straight forward. I only had one comment > > regarding the portDS and defaultDS, which I assume refer to "Domain > > Specific"? > > So the DS in the names stands for "Data Set", and I added the prefix > because the profile has both a per-port and a per-clock attribute > called localPriority. In fact the profile refers to these are > "defaultDS.localPriority" and "portDS.localPriority". > Hah, I thought it meant "domain specific". > [ BTW, all of our configuration options are simple strings, and so the > dot carries no special meaning. We don't really have subclasses. ] > [ Yes, I assumed they had no real meaning and were just used for semantics ] > > Would it make sense to subclass this into .telecom. so > > it's more obvious this is very specific to the telecom profile? > > Hm, that wouldn't be worst idea, especially if we accumulate more and > more profile specific options over time. > > G8275.defaultDS.localPriority 128 > G8275.portDS.localPriority 128 > G8275.notSlave 0 > > How does that strike you? > > Thanks, > Richard That looks good. It makes it obvious that the option is profile specific. Thanks, Jake ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
