On Thu, Aug 31, 2017 at 10:40:44PM +0200, Richard Cochran wrote:
> On Thu, Aug 31, 2017 at 09:55:35PM +0800, Hangbin Liu wrote:
> > When we use a PI controller as default, after switch phc index, we create a
> > new servo. But we forget to init the servo sync interval, and left s->ki as
> > 0.0.
>
> No, we don't forget the sync interval. See the caller port_dispatch().
Ah, sorry, didn't notice this.
if (p->jbod && next == PS_UNCALIBRATED) {
if (clock_switch_phc(p->clock, p->phc_index)) {
p->last_fault_type = FT_SWITCH_PHC;
port_dispatch(p, EV_FAULT_DETECTED, 0);
return;
}
clock_sync_interval(p->clock, p->log_sync_interval);
}
When we add the p->jbod check, we only support multi clock device with
boundary clock. Since now the phc index may also changed with ordinary
clock. Could we remove the p->jbod check?
Thanks
Hangbin
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
