Sunday, July 1, 2018 7:18 AM > > > +int process_signaling(struct port *p, struct ptp_message *m) > > > > I suggest: port_signaling_tx or port_signaling_process or > > port_process_signaling
> That would break the pattern. > We already have: That's true, but there is also a pattern to start each global function with the name of the file, like: port_open() clock_create() transport_open() etc Isn't it good to follow the same pattern in all files and fix those which not follow. Then after merge maybe have a walk through of each global function and fix the functions without prefix so it is clear where it belong when you read the code. But it is only a suggestion. /Anders ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
