On Mon, Jun 18, 2018 at 05:40:11PM -0700, Cliff Spradlin via Linuxptp-devel
wrote:
> It can be useful to see the quality of the grandmaster's clock,
> especially as it changes over time (such as during GPS holdover).
> + pr_info("class %hhu accuracy 0x%02hhx variance 0x%04hx",
> + best->dataset.quality.clockClass,
> + best->dataset.quality.clockAccuracy,
> + best->dataset.quality.offsetScaledLogVariance);
I'm not wild about this patch. I'd like to keep the logging to the
minimum that allows the sys admin to see that PTP is working or not,
like the port state transitions.
I would say that clockClass is actually uninteresting, since you know
that the BMCA selects the best one. Sure you might want to see this
or that attribute from the dozens available, but what is important to
you might be meaningless to someone else.
I think this sort of thing is better served by monitoring tools, like
pmc. And soon we are getting SNMP, too...
Thanks,
Richard
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
