On Wed, Aug 01, 2018 at 11:52:11PM +0000, Keller, Jacob E wrote:
> 
> 
> > -----Original Message-----
> > From: Michael Walle [mailto:mich...@walle.cc]
> > Sent: Tuesday, July 31, 2018 1:46 AM
> > To: linuxptp-devel@lists.sourceforge.net
> > Subject: [Linuxptp-devel] [PATCH] msg: Make timestamp_{post_recv,
> > pre_send}() symmetric
> > 
> > While the pre_send() converts the timestamp inside the packet, the
> > post_recv() just copies (and converts) it into a special field inside
> > the message structure. But it doesn't convert the timestamp inside the
> > packet. Fix this.
> > 
> 
> This seems reasonable to me.

Except that we don't actually use the field in the packet buffer, so
the conversion is extra work for no benefit.

Thanks,
Richard

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to