Thanks for your input. The code generate error rightfully, the message is misleading.
I will correct the code in sk.c to generate a more accurate error messaging. I did saw that the daemon keeps running, is that the correct behaviour for sk_timestamping_init() returning error (err = -1)? I will send a new patch today or tomorrow. Yours Erez ________________________________________ From: Richard Cochran [richardcoch...@gmail.com] Sent: 02 August 2018 18:24 To: Erez Geva Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH] config: Add hardware time stamp filter setting mode On Sat, Jul 14, 2018 at 11:17:42PM +0200, Erez Geva wrote: > Add global option for the hardware time stamp setting. > The function could: > Normally set the filters as the PTP daemon require. > Check that the filters are proper but do not change them. > Full, set the RX filter to all and the TX filter as the PTP daemon require. I *think* the code is now ok, but still the log messages don't make sense. I ran the following test: # ./hwstamp_ctl -i eth0 current settings: tx_type 1 rx_filter 0 # ./ptp4l -m -q -i eth0 --hwts_filter=check ptp4l.arm[439.518]: selected /dev/ptp0 as PTP clock * ptp4l.arm[439.529]: driver rejected most general HWTSTAMP filter * ptp4l.arm[439.529]: ioctl SIOCSHWTSTAMP failed: Success ptp4l.arm[439.537]: port 1: INITIALIZING to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED) ptp4l.arm[439.537]: port 0: INITIALIZING to LISTENING on INIT_COMPLETE * These two lines are misleading. I'm holding off applying this patch for now. Once the messages are sorted out, we can queue this up for v2.1. Thanks, Richard ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
