On Sun, Aug 05, 2018 at 07:19:21PM +0200, Erez Geva wrote:
> Add global option for the hardware time stamp setting.
Please, when re-submitting a patch, update the subject with an
increasing version number. For example:
Subject: [PATCH v2] config: Add hardware time stamp filter setting mode
> + if (cfg.tx_type != tx_type ||
> + (cfg.rx_filter != rx_filter &&
> + cfg.rx_filter != rx_filter2 &&
> + cfg.rx_filter != HWTSTAMP_FILTER_ALL &&
> + cfg.rx_filter != HWTSTAMP_FILTER_PTP_V2_EVENT)) {
> pr_debug("driver changed our HWTSTAMP options");
> + pr_debug("tx_type %d not %d", cfg.tx_type, tx_type);
> + pr_debug("rx_filter %d not %d or %d", cfg.rx_filter, rx_filter,
> + rx_filter2);
> + pr_err("The current filter does not match the required");
> + return -1;
> }
This is better, but the "driver changed our HWTSTAMP options" message
doesn't apply anymore, does it?
Also, the test for
cfg.rx_filter != HWTSTAMP_FILTER_PTP_V2_EVENT
is redundant because we already tested for
cfg.rx_filter != rx_filter
Thanks,
Richard
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
