On Sat Mar 29 15:26:42 2025 +0100, Christophe JAILLET wrote:
> 'struct i2c_algorithm' is not modified in this driver.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text    data     bss     dec     hex filename
>    6645     216      16    6877    1add 
> drivers/media/common/b2c2/flexcop-i2c.o
> 
> After:
> =====
>    text    data     bss     dec     hex filename
>    6721     160      16    6897    1af1 
> drivers/media/common/b2c2/flexcop-i2c.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/common/b2c2/flexcop-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---

diff --git a/drivers/media/common/b2c2/flexcop-i2c.c 
b/drivers/media/common/b2c2/flexcop-i2c.c
index 1f1eaa807811..21edf870d927 100644
--- a/drivers/media/common/b2c2/flexcop-i2c.c
+++ b/drivers/media/common/b2c2/flexcop-i2c.c
@@ -209,7 +209,7 @@ static u32 flexcop_i2c_func(struct i2c_adapter *adapter)
        return I2C_FUNC_I2C;
 }
 
-static struct i2c_algorithm flexcop_algo = {
+static const struct i2c_algorithm flexcop_algo = {
        .master_xfer    = flexcop_master_xfer,
        .functionality  = flexcop_i2c_func,
 };

Reply via email to