On Thu May 22 13:56:43 2025 -0400, Frank Li wrote: > dma_set_mask_and_coherent() never return failure when mask bigger than > 32bit. > > See commit f7ae20f2fc4e ("docs: dma: correct dma_set_mask() sample code") > > So remove return value check for dma_set_mask_and_coherent(). > > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed-off-by: Frank Li <frank...@nxp.com> > Link: https://lore.kernel.org/r/20250522-8qxp_camera-v5-5-d4be869fd...@nxp.com > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>
Patch committed. Thanks, Hans Verkuil drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --- diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c index 015350c6f278..073ea5912de3 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -444,11 +444,7 @@ static int mxc_isi_probe(struct platform_device *pdev) } dma_size = isi->pdata->has_36bit_dma ? 36 : 32; - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size)); - if (ret) { - dev_err(dev, "failed to set DMA mask\n"); - return ret; - } + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size)); pm_runtime_enable(dev);