Sorry about the late reply, half of my inbox vanished in smoke and I had to restore this one from backup.
On Mon, Dec 28, 2009 at 06:07:26PM +0100, Enrico Ros wrote: > xf86-input-wacom vs. bamboo-34: > * Half of the B changes already merged and shipped in 0.10.3 > * Greatly improved since the merge (thanks to Ping) > * There is one B patch remaining, bringing some Touch logic [1]. This is the > last bit of B changes to merge > Remaining steps: > * pull [1] into xf86-input-wacom and apply it to linuxwacom/src/xdrv - this > will sync all the B changes Thanks for this work! One thing I have to note here - if you only have a single patch it's easier to just send the patch to the list instead of a pull request. Pull requests are great for patches that have been reviewed but for patches that may still be in discussion it's easier to reply to something in-line. > [1] git://gitorious.org/linuxwacom/xf86-input-wacom.git - 'for-whot' branch As for the patch itself: Is it possible to use a descriptive enum for the touchpad modes? 1, 2, 3 isn't really self-explanatory. The rest of the patch looks good though. Cheers, Peter ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
