Tested-by: Ping Cheng <pingli...@gmail.com>
for the whole set. The patchset is fine except 0003-Move-wcmTilt2Rotation
has 2 extra trailing whitespaces.
There is an issue with the rotation output from "xinput test". The output
is wrong although the rotation value posted from the driver is correct (I
traced into the driver code). Considering no one has reported this
problem, it is safe to assume this is a low priority issue. The fix to the
output problem should go into a separate patchset if it is a driver issue.
Ping
2010/1/17 Przemysław Firszt <prz...@firszt.eu>
> Dnia 2010-01-16, sob o godzinie 13:45 -0800, Ping Cheng pisze:
> > 2010/1/16 Przemysław Firszt <prz...@firszt.eu>:
> > > Dnia 2010-01-14, czw o godzinie 17:43 -0800, Ping pisze:
> [..]
> > The following lines in the third patch have extra tab-indent:
> >
> > + /* other tilt-enabled devices need to apply round() after
> this call */
> > + if (tilt_x || tilt_y)
> > + rotation = ((180.0 * atan2(-tilt_x,tilt_y)) / M_PI)
> + 180.0;
> > +
> > + /* Intuos4 mouse has an (180-5) offset */
> > + ds->rotation = round((360.0 - rotation + 180.0 - 5.0) *
> 5.0);
> > + ds->rotation %= 1800;
> > +
> > + if (ds->rotation >= 900)
> > + ds->rotation = 1800 - ds->rotation;
> > + else
> > + ds->rotation = -ds->rotation;
> >
> > I will test the set once the above is fixed.
> My fault - thanks for tha catch. That version should be OK
> --
> Przemo
>
>
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
