Dnia 2010-01-18, pon o godzinie 15:48 -0800, Ping Cheng pisze:
> for the whole set. The patchset is fine except
> 0003-Move-wcmTilt2Rotation has 2 extra trailing whitespaces.
Patch fixing spaces attached.
> There is an issue with the rotation output from "xinput test". The
> output is wrong although the rotation value posted from the driver is
> correct (I traced into the driver code). Considering no one has
> reported this problem, it is safe to assume this is a low priority
> issue. The fix to the output problem should go into a separate
> patchset if it is a driver issue.
I'm adding it to my list of reasons to buy intuos4 ;-)
--
Cheers,
Przemo
>From a552b7777d34105fec12de70eb585c8f4e51e9a9 Mon Sep 17 00:00:00 2001
From: Przemo Firszt <prz...@firszt.eu>
Date: Tue, 19 Jan 2010 20:34:12 +0000
Subject: [PATCH 4/4] Remove trailing spaces from wcmFilter.c
Signed-off-by: Przemo Firszt <prz...@firszt.eu>
---
src/wcmFilter.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/wcmFilter.c b/src/wcmFilter.c
index 06a1f8c..e14b436 100644
--- a/src/wcmFilter.c
+++ b/src/wcmFilter.c
@@ -1,6 +1,6 @@
/*
* Copyright 1995-2002 by Frederic Lepied, France. <lep...@xfree86.org>
- * Copyright 2002-2008 by Ping Cheng, Wacom. <pi...@wacom.com>
+ * Copyright 2002-2008 by Ping Cheng, Wacom. <pi...@wacom.com>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
@@ -13,7 +13,7 @@
* GNU Lesser General Public License for more details.
*
* You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
+ * along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*/
@@ -144,7 +144,7 @@ static void filterCurveToLine(int* pCurve, int nMax, double x0, double y0,
/* calc split point */
xm = (x1 + x2) / 2; ym = (y1 + y2) / 2;
-
+
/* calc control points and midpoint */
c1 = (x01 + xm) / 2; d1 = (y01 + ym) / 2;
c2 = (x32 + xm) / 2; d2 = (y32 + ym) / 2;
@@ -227,13 +227,13 @@ static void filterIntuosStylus(WacomCommonPtr common, WacomFilterStatePtr state,
ds->tiltx = tx / common->wcmRawSample;
if (ds->tiltx > common->wcmMaxtiltX/2-1)
- ds->tiltx = common->wcmMaxtiltX/2-1;
+ ds->tiltx = common->wcmMaxtiltX/2-1;
else if (ds->tiltx < -common->wcmMaxtiltX/2)
ds->tiltx = -common->wcmMaxtiltX/2;
ds->tilty = ty / common->wcmRawSample;
if (ds->tilty > common->wcmMaxtiltY/2-1)
- ds->tilty = common->wcmMaxtiltY/2-1;
+ ds->tilty = common->wcmMaxtiltY/2-1;
else if (ds->tilty < -common->wcmMaxtiltY/2)
ds->tilty = -common->wcmMaxtiltY/2;
}
@@ -249,7 +249,7 @@ int wcmFilterCoord(WacomCommonPtr common, WacomChannelPtr pChannel,
* cannot be fixed, return 1 such that the data is discarded. */
WacomDeviceState *pLast;
- int *x, *y, i;
+ int *x, *y, i;
DBG(10, common, "common->wcmRawSample = %d \n", common->wcmRawSample);
x = pChannel->rawFilter.x;
@@ -290,7 +290,7 @@ int wcmFilterIntuos(WacomCommonPtr common, WacomChannelPtr pChannel,
/*****************************************************************************
* wcmTilt2R -
- * Converts tilt X and Y to rotation, for Intuos4 mouse for now.
+ * Converts tilt X and Y to rotation, for Intuos4 mouse for now.
* It can be used for other devices when necessary.
****************************************************************************/
@@ -308,7 +308,7 @@ void wcmTilt2R(WacomDeviceStatePtr ds)
ds->rotation = round((360.0 - rotation + 180.0 - 5.0) * 5.0);
ds->rotation %= 1800;
- if (ds->rotation >= 900)
+ if (ds->rotation >= 900)
ds->rotation = 1800 - ds->rotation;
else
ds->rotation = -ds->rotation;
--
1.6.6
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
