On Thu, Mar 4, 2010 at 8:09 PM, Peter Hutterer <[email protected]> wrote: > On Thu, Mar 04, 2010 at 07:29:05PM -0600, Chris Bagwell wrote: >> For all in series: >> >> Reviewed-by: Chris Bagwell <[email protected]> >> >> For this patch, I also noticed this mis-placed code while reviewing >> isdv4GetRanges() recently. It seems the basic issue is that serial >> ports can return variable sized packets based on what user is doing. > > Ping, can you confirm this? is this true? > As I understood it so far, the data size is constant once the tablet has > been initialized and it's more model-specific than anything else. >
Yes, it would be great to hear from Ping. I had thought that until yesterday as well. Based on bug tracker #2952501, it shows two packet lengths in xorg.log. Looking closer at isdv4Parse(), it looks like one packet size for touch events and another packet length for pen events. And code is taking advantage of that fact. Once we know the answer though, it looks like we can eventually remove code from init phase or we can remove code from parse phase. One of them seems redundant. Chris ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
