On Wed, Mar 24, 2010 at 10:54:05PM -0700, Ping Cheng wrote: > I acked this patch too soon, There is another place that sets the > mode to absolute: > > in wcmDevSwitchModeCall of wcmXComand.c: > > /* Pad is always in absolute mode.*/ > if (IsPad(priv)) > return (mode == Absolute) ? Success : XI_BadMode; > > Peter, can you update your patch to include this case? Thank you.
thank you, fixed, will push in a minute. Cheers, Peter > On Wed, Mar 24, 2010 at 5:51 PM, Peter Hutterer > <[email protected]> wrote: > > Fixes Intuos3 scrolling issues. > > > > The pad cannot be in absolute mode as it sends the axis values to the > > server. Since the pad never gets x/y coordinates from the tablet the server > > will fill in the defaults (0/0) for it - even if first_valuator is always > > > 1. This results in the pointer being reset to the screen origin each time > > the pad's scroll strip is used. > > > > Signed-off-by: Peter Hutterer <[email protected]> > > --- > > src/wcmValidateDevice.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c > > index f153cd2..51b16de 100644 > > --- a/src/wcmValidateDevice.c > > +++ b/src/wcmValidateDevice.c > > @@ -333,9 +333,9 @@ int wcmParseOptions(LocalDevicePtr local) > > */ > > } > > > > - /* Pad is always in absolute mode. */ > > + /* Pad is always in relative mode. */ > > if (IsPad(priv)) > > - priv->flags |= ABSOLUTE_FLAG; > > + priv->flags &= ~ABSOLUTE_FLAG; > > > > /* Store original local Core flag so it can be changed later */ > > if (local->flags & (XI86_ALWAYS_CORE | XI86_CORE_POINTER)) > > -- > > 1.6.6.1 > > > > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
