On Mon, Aug 23, 2010 at 2:57 PM, Mike Auty <[email protected]> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> So,
>
> Further to my last report, I've done a git bisection

Thank you Mike for looking into the details.

> and found that the
> problem arises in commit 3b57ca0f80c5c8994b5b1e3d3f904cfe727951f2, which
> does indeed appear to alter the way mouse wheel movements are handled.
> After this commit, on a USB Graphire 3, the mouse wheel returns "Button
> 5" in xev for both positive and negative rotations.
>
> I haven't figured out what the code does yet,

The code was:

        rw = data[7] & 0x04 ? (data[7] & 0x03)-4 : (data[7] & 0x03);
        wacom_report_rel(wcombo, REL_WHEEL, -rw);

it is changed to:

        rw = (signed)(data[7] & 0x04) - (data[7] & 0x03);
        input_report_rel(input, REL_WHEEL, rw);

I guess they should report the same value? I don't have a graphire to test with.

> but I was really hoping
> for some help from people who knew what it did and what was going on?

What was going on? I am not sure (I am not kidding :). I guess we
wanted to simplify the logical?

> Even just someone letting me know if I'm reporting this in the right
> place would be useful.  Thanks...

You are reporting it at the right place, as you always did, Mike.

Ping

------------------------------------------------------------------------------
Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
Be part of this innovative community and reach millions of netbook users 
worldwide. Take advantage of special opportunities to increase revenue and 
speed time-to-market. Join now, and jumpstart your future.
http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to