-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 25/08/10 10:45, Ping Cheng wrote: > > It must be an issue in the kernel driver. Maybe the signed cast is > wrong. I'll review your patch once you have it ready. >
Found it, although it wasn't quite where I expected it. Apparently my Graphire 3 doesn't talk either WACOM_G4 or WACOM_MO, and so it was the change of cast from -(signed char)data[6] to -(signed)data[6] that caused the problems (presumably signed -1 is stored as unsigned 0xff, so negating that and putting it into an int would be -255, which is what I was seeing). I don't know whether the value for WACOM_G4 should be (signed char) as well, but I suspect that because all the values are masked off by 0x03 or 0x04, it shouldn't cause a problem. So I've attached the patch. I'm not sure how the patching process works, will this make it into 2.6.35.4 as well as 2.6.36, or will it only get pulled for 2.6.36? Thanks for all the advice and help in tracking down the problem! Mike 5:) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iEYEARECAAYFAkx1JLkACgkQu7rWomwgFXophgCgpdI6KjMio1kF3duiG6X2yCk7 6s8AoLeSto/tU6MIWqLCLtauFN1fSUn2 =X1Rq -----END PGP SIGNATURE-----
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 415f630..6cad0f9 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -213,7 +213,7 @@ static int wacom_graphire_irq(struct wacom_wac *wacom)
rw = (signed)(data[7] & 0x04) - (data[7] &
0x03);
} else {
input_report_abs(input, ABS_DISTANCE, data[7] &
0x3f);
- rw = -(signed)data[6];
+ rw = -(signed char)data[6];
}
input_report_rel(input, REL_WHEEL, rw);
}
2.6.35.3-wacom-graphire3-mousewheel-fix.patch.sig
Description: PGP signature
------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
