On Mon, Aug 22, 2011 at 8:58 PM, Peter Hutterer <peter.hutte...@who-t.net>wrote:

> Rotation specifies the rotation for the virtual input area, not the
> physical
> tablet rotation (which goes the other way). Reword the man pages to point
> this out.
>
> Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>


Acked-by: Ping Cheng <pingli...@gmail.com> with comments inline.

Ping


> ---
> I've taken the easy way out, simply stating that it's the tablet area that
> is rotated. Going a different direction than GNOME would be too painful,
> especially since at the same time we'd still have to support the old
> rotation value more-or-less indefinitely.


If we view the xsetwacom function in a user's perspective, it is doing the
right thing. Users have no knowledge of what the driver is doing. But they
know they have rotated the display clockwise and the cursor does not follow
their tool tip any more. So, they want the tablet work clockwise (not
counterclockwise) as well.

Right or wrong, really depends on who is going to use it.


> . man/wacom.man     |   10 +++++-----
>  man/xsetwacom.man |   10 +++++-----
>  2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/man/wacom.man b/man/wacom.man
> index 85cfa1f..ef24808 100644
> --- a/man/wacom.man
> +++ b/man/wacom.man
> @@ -164,11 +164,11 @@ system cursor moves when user touches the tablet.
>  Default to "on" for
>  Tablet PCs with touch feature; "off" for all other models.
>  .TP 4
>  .B Option \fI"Rotate"\fP \fI"CW"|"CCW"|"HALF"|"NONE"\fP
> -rotates the tablet orientation counterclockwise (CCW) or clockwise (CW) or
> 180 degrees (HALF).
>

Sorry for using "tablet" instead of the right term.


> -If you have specific tablet mappings, i.e. TopX/Y or BottomX/Y were set,
> the mapping will be
> -applied before rotation. Rotation must be applied to the parent device
> -(usually the stylus), rotation settings on hotplugged devices will be
> -ignored. The default is "NONE".
> +rotates the input area on the tablet counterclockwise (CCW) or clockwise
> +(CW) or 180 degrees (HALF).  If you have specific tablet mappings, i.e.
> +TopX/Y or BottomX/Y were set, the mapping will be applied before rotation.
> +Rotation must be applied to the parent device (usually the stylus),
> rotation
> +settings on hotplugged devices will be ignored. The default is "NONE".


Do we want to support hotplugging with options?


>  .TP 4
>  .B Option \fI"PressCurve"\fP \fI"x1,y1,x2,y2"\fP
>  sets pressure curve by control points x1, y1, x2, and y2.  Their values
> are in range
> diff --git a/man/xsetwacom.man b/man/xsetwacom.man
> index 539f405..340e2a2 100644
> --- a/man/xsetwacom.man
> +++ b/man/xsetwacom.man
> @@ -151,11 +151,11 @@ Set the sample window size (a sliding average
> sampling window) for incoming
>  input tool raw data points.  Default:  4, range of 1 to 20.
>  .TP
>  \fBRotate\fR none|half|cw|ccw
> -Set the tablet to the given rotation:
> -  none: the tablet is not rotated and uses its natural rotation
> -  half: the tablet is rotated by 180 degrees (upside-down)
> -  cw: the tablet is rotated 90 degrees clockwise
> -  ccw: the tablet is rotated 90 degrees counter-clockwise
> +Set the input area of the tablet to the given rotation:
> +  none: uses its natural rotation
> +  half: rotate by 180 degrees (upside-down)
> +  cw: rotate 90 degrees clockwise
> +  ccw: rotate 90 degrees counter-clockwise
>
>  Rotation is a tablet-wide option: rotation of one tool affects all other
> tools
>  associated with the same tablet. When the tablet is physically rotated,
> rotate
> --
> 1.7.6
>
>
> ------------------------------------------------------------------------------
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
> user administration capabilities and model configuration. Take
> the hassle out of deploying and managing Subversion and the
> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
> _______________________________________________
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
user administration capabilities and model configuration. Take 
the hassle out of deploying and managing Subversion and the 
tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to