On Sun, Jun 26, 2011 at 5:44 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Sun, Jun 26, 2011 at 07:40:35PM -0500, Chris Bagwell wrote: >> On Sun, Jun 26, 2011 at 7:31 PM, Peter Hutterer >> <peter.hutte...@who-t.net> wrote: >> > On Sat, Jun 25, 2011 at 01:05:52PM -0500, ch...@cnpbagwell.com wrote: >> >> From: Chris Bagwell <ch...@cnpbagwell.com> >> >> >> >> We really need to add hooks to query pre-existing device state when >> >> input driver starts up because slot ID is almost never sent when >> >> touching 1 finger to screen. >> >> >> >> In mean time, it makes sense to default device_type to most likely >> >> value of TOUCH (the T in MT) for this function used only by MT >> >> devices. >> >> >> >> The default of zero is causing some events to be filtered mistakenly. >> >> >> >> Signed-off-by: Chris Bagwell <ch...@cnpbagwell.com> >> > >> > Merged 1/4 and this one for now, see my comments to 2/4 for the rest. >> > >> > Cheers, >> > Peter >> >> Can you verify you meant 2/4 and 4/4 were merged? 2/4 is the simple >> debug statement. > > yes, sorry. I meant 2 and 4 were merged. They arrived out-of-order in my > inbox so I got the numbers mixed up. > > Cheers, > Peter >
I was finishing my final round of testing in preparation for 0.12.0 when I noticed this commit caused the pen and touch tools on my MT USB ISDv4 tablet PC to quit working. At first I thought it might be because setting device_type before the loop causes it to never execute, but fixing that still results in the pen having issues (touch starts working again though). Chris, can you remember any details about the device filtering problems this patch was fixing? I'm considering reverting this patch for 0.12 but would like to have a little more information before doing that. Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
