On Sun, Feb 26, 2012 at 03:50:17PM +0000, Przemo Firszt wrote: > This patch adds reporting of distance of tool to the tablet surface. Maximum > reported value is 63 (0x3F). > > Signed-off-by: Przemo Firszt <prz...@firszt.eu> > --- > drivers/hid/hid-wacom.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c > index 49b9178..93cd8ef 100644 > --- a/drivers/hid/hid-wacom.c > +++ b/drivers/hid/hid-wacom.c > @@ -362,6 +362,7 @@ static void wacom_i4_parse_pen_report(struct wacom_data > *wdata, > input_report_abs(input, ABS_X, x); > input_report_abs(input, ABS_Y, y); > input_report_abs(input, ABS_PRESSURE, pressure); > + input_report_abs(input, ABS_DISTANCE, ((data[9] >> 2) & 0x3f));
without looking at the code outside the diff context, it appears that x, y and pressure have temporary variables. it would improve readability if distance had one too. otherwise, looks sane. Acked-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > input_report_abs(input, ABS_MISC, wdata->id); > input_event(input, EV_MSC, MSC_SERIAL, wdata->serial); > input_report_key(input, wdata->tool, 1); > @@ -484,6 +485,7 @@ static int wacom_input_mapped(struct hid_device *hdev, > struct hid_input *hi, > input_set_abs_params(input, ABS_X, 0, 40640, 4, 0); > input_set_abs_params(input, ABS_Y, 0, 25400, 4, 0); > input_set_abs_params(input, ABS_PRESSURE, 0, 2047, 0, 0); > + input_set_abs_params(input, ABS_DISTANCE, 0, 63, 0, 0); > break; > } > > -- > 1.7.6.4 > > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > Linuxwacom-devel mailing list > Linuxwacom-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel > ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
