Dnia 2012-02-27, pon o godzinie 08:53 +1000, Peter Hutterer pisze:
> On Sun, Feb 26, 2012 at 03:50:17PM +0000, Przemo Firszt wrote:
> > This patch adds reporting of distance of tool to the tablet surface. Maximum
> > reported value is 63 (0x3F).
> > 
> > Signed-off-by: Przemo Firszt <prz...@firszt.eu>
> > ---
> >  drivers/hid/hid-wacom.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> > index 49b9178..93cd8ef 100644
> > --- a/drivers/hid/hid-wacom.c
> > +++ b/drivers/hid/hid-wacom.c
> > @@ -362,6 +362,7 @@ static void wacom_i4_parse_pen_report(struct wacom_data 
> > *wdata,
> >             input_report_abs(input, ABS_X, x);
> >             input_report_abs(input, ABS_Y, y);
> >             input_report_abs(input, ABS_PRESSURE, pressure);
> > +           input_report_abs(input, ABS_DISTANCE, ((data[9] >> 2) & 0x3f));
> 
> without looking at the code outside the diff context, it appears that x, y
> and pressure have temporary variables. it would improve readability if
> distance had one too.
> 
> otherwise, looks sane. Acked-by: Peter Hutterer <peter.hutte...@who-t.net>
> 
Thanks Peter, new patch on the way.

-- 
Przemo


------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to