On Wed, Feb 12, 2014 at 11:00 AM, Egbert Eich <e...@freedesktop.org> wrote: > From: Egbert Eich <e...@suse.com> > > The following set of patches fixes the build of the > unit tests for me and gits rid of most of the annoying > compiler warnings when building both driver and test > suite. > > Egbert Eich (8): > Fix type mismatch in test suite > Fix loads of 'redundand declaration' warnings in test suite > Add missing symbol xf86PrintChipsets() for test suite > Make tested static functions non-static for test suite > Fix warning about discarding 'const' qualifier > Fix '-Wuninitialized' warnings > Fix spurious '-Wshadow' warning > Get rid of spurious 'format not a string literal' warnings > > src/Makefile.am | 5 ++ > src/common.mk | 4 +- > src/wcmCommon.c | 10 +-- > src/wcmConfig.c | 2 +- > src/wcmUSB.c | 2 +- > src/xf86Wacom.c | 2 +- > src/xf86Wacom.h | 35 ++++++++-- > src/xf86WacomDefs.h | 2 +- > test/Makefile.am | 15 +++-- > test/fake-symbols.c | 9 ++- > test/fake-symbols.h | 184 > ++++++++++++++++++++++++++++------------------------ > test/wacom-tests.c | 6 +- > 12 files changed, 167 insertions(+), 109 deletions(-) > > -- > 1.8.1.4 >
Everything in this patch set looks pretty reasonable. I still need to read through the ones not part of this set, but for these eight (aside from the three I commented on): Reviewed-by: Jason Gerecke <killert...@gmail.com> Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
