On Fri, Feb 14, 2014 at 07:50:32AM +1000, Peter Hutterer wrote:
> On Thu, Feb 13, 2014 at 02:30:20PM +0100, Egbert Eich wrote:
> > From: Egbert Eich <e...@suse.com>
> >
> > With '-Wformat-nonliteral' gcc kindly warns us that it cannot check the
> > arguments of a scanf statement as the format string is not literal.
> > This happens if the format string itself is pointer.
> > Since the list of format strings only has two elements the same thing
> > can be achieved in code directly.
> >
> > Signed-off-by: Egbert Eich <e...@suse.com>
> > ---
> > + * @param common - set key bits, vendor_id and tablet_id
>
> no dash after common
Agreed.
>
> > + */
> > +static Bool get_keys_vendor_tablet_id(char *name, WacomCommonPtr common)
>
> linkebreak after the return type please
Peter, please check the rest of the file. This is not done anywhere
else there.
If you insist on linebreaks after the return type I will supply a
separate patch changing it *everywhere* in this file.
> > -static ISDV4ModelDesc*
> > -model_from_sysfs(const InputInfoPtr pInfo, int fd, int *id)
> > +static Bool get_sysfs_id(InputInfoPtr pInfo, char *buf, int buf_size)
>
> linebreak after return type please
Same.
Cheers,
Egbert.
------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
