On Fri, Feb 14, 2014 at 07:50:26AM +1000, Peter Hutterer wrote:
> >  
> > -_X_EXPORT void
> > -InitValuatorAxisStruct(DeviceIntPtr dev, int axnum, Atom label, int 
> > minval, int maxval,
> > -                  int resolution, int min_res, int max_res, int mode)
> > +
> > +#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) > 14
> > +_X_EXPORT Bool InitValuatorAxisStruct(DeviceIntPtr dev, int axnum, Atom 
> > label,
> 
> please split this up into two lines for
> 
> _X_EXPORT Bool 
> InitValuatorAxisStruct...

Ok, will do.

> 
> also, the rest of this file uses spaces insted of tabs (sorry), please just
> re-indent accordingly.
> 

No, it isn't. 
In fake-symbols.c there are several functions towards the end which are 
indented with tabs.
I've replaced any tabs with spaces in my code now regardless.

Cheers,
        Egbert.

------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to