Peter Hutterer writes:
> > > hmm, if you're using strdupa anyway you dont need the char const*
> > > anymore?
> > >
> >
> > No, these were two separate issues: (InputInfoPtr)->name is (char *)
> > not (char const *) thus we need the strdupa() while the change for name
> > in WacomTool is required because of:
> > else ser->name = ""; /*no name yet*/
> > in wcmValidateDevice.c - ie. the opposite issue.
>
> oh, right. I'm happy with the second bit then, but the first one should be
> fixed by strdup'ing the temporary name. Looks like we currently leak the
> name anyway, wcmFreeCommon doesn't release it and the name is strdup'd if
> there is a proper one. So I think we should strdup() it here too, and you
> get bonus points for fixing the leak in a separate patch ;)
>
Yup. You're right. Fixed.
Cheers,
Egbert.
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
