On Mon, Feb 17, 2014 at 10:16:52AM +0100, Egbert Eich wrote:
> From: Egbert Eich <e...@suse.com>
> 
> This code is entirely irrelevant as it is called immediately after
> rebasePressure() which already ensures that minPressure is the
> minimum of minPressure and current pressure unless one mistrusts
> the implementation of min().
> 
> Signed-off-by: Egbert Eich <e...@suse.com>

Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>

Cheers,
   Peter

> ---
> This replaces:
> [PATCH] Fix message if the detected pressure falls below the initially 
> detected pressure
> 
>  src/wcmCommon.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/src/wcmCommon.c b/src/wcmCommon.c
> index 3cb93ee..97f7765 100644
> --- a/src/wcmCommon.c
> +++ b/src/wcmCommon.c
> @@ -1072,14 +1072,6 @@ normalizePressure(const WacomDevicePtr priv, const 
> WacomDeviceState *ds)
>       double pressure;
>       int p = ds->pressure;
>  
> -     if (p < priv->minPressure)
> -     {
> -             LogMessageVerbSigSafe(X_ERROR, 0,
> -                                   "%s: Pressure %d lower than expected 
> minimum %d. This is a bug.\n",
> -                                   priv->pInfo->name, ds->pressure, 
> priv->minPressure);
> -             p = priv->minPressure;
> -     }
> -
>       /* normalize pressure to 0..FILTER_PRESSURE_RES */
>       pressure = xf86ScaleAxis(p - priv->minPressure,
>                                FILTER_PRESSURE_RES, 0,
> -- 
> 1.8.1.4
> 

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to