granata.enrico added inline comments. ================ Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:37 @@ +36,3 @@ + return false; + stream.Printf("%d %s", (int)value.GetValueAsSigned(), value.GetValue()); + return true; ---------------- I would definitely not stop the revision for this but I wonder if it would make sense to try and discover whether "char" is signed or unsigned from the type itself?
================ Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:835 @@ +834,3 @@ + + if (!MI_add_summary(miCategory, "char", MI_char_summary_provider, + lldb::eTypeOptionHideValue | lldb::eTypeOptionSkipPointers)) ---------------- Should you also cover "signed char" and "unsigned char" here? http://reviews.llvm.org/D13799 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits