abidh added a comment. Please also indicate if a revision is dependent on some other revisions that has not yet been committed as this one is on http://reviews.llvm.org/D13657.
================ Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:126 @@ -125,12 +125,3 @@ { - if (m_bHandleCharType && IsCharType()) - { - vwrValue = GetSimpleValueChar(); - return MIstatus::success; - } - else - { - const char *pValue = m_rValue.GetValue(); - vwrValue = pValue != nullptr ? pValue : m_pUnkwn; - return MIstatus::success; - } + vwrValue = GetValueSummary(!m_bHandleCharType && IsCharType(), m_pUnkwn); + return MIstatus::success; ---------------- As the condition is changed, can you explain a little bit in which scenario, you want to pass true/false here for first parameter. ================ Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:131 @@ -139,12 +130,3 @@ { - if (m_bHandleCharType && IsPointeeCharType()) - { - vwrValue = GetSimpleValueCStringPointer(); - return MIstatus::success; - } - else - { - const char *pValue = m_rValue.GetValue(); - vwrValue = pValue != nullptr ? pValue : m_pUnkwn; - return MIstatus::success; - } + vwrValue = GetValueSummary(!m_bHandleCharType && IsPointeeCharType(), m_pUnkwn); + return MIstatus::success; ---------------- Same as above. http://reviews.llvm.org/D13799 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits