================ @@ -949,75 +952,76 @@ static std::optional<T> getArgumentsIfRequest(const Message &pm, return args; } -llvm::Error DAP::Loop() { - // Can't use \a std::future<llvm::Error> because it doesn't compile on - // Windows. - std::future<lldb::SBError> queue_reader = - std::async(std::launch::async, [&]() -> lldb::SBError { - llvm::set_thread_name(transport.GetClientName() + ".transport_handler"); - auto cleanup = llvm::make_scope_exit([&]() { - // Ensure we're marked as disconnecting when the reader exits. - disconnecting = true; - m_queue_cv.notify_all(); - }); - - while (!disconnecting) { - llvm::Expected<Message> next = - transport.Read<protocol::Message>(std::chrono::seconds(1)); - if (next.errorIsA<TransportEOFError>()) { - consumeError(next.takeError()); - break; - } +Status DAP::TransportHandler() { ---------------- ashgti wrote:
We ran into issues when building with MSVC 2019 and using an std::future<llvm::Error> (on line 1023), see #137388 https://github.com/llvm/llvm-project/pull/148300 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits