tedwoodward wrote:

> Please fix the formatting before landing - 
> https://github.com/llvm/llvm-project/actions/runs/16232166455/job/45836933279?pr=145793.

I disagree with the Python formatting here. It doesn't need to indent inside a 
`"""` comment string; it's not Python code. And other examples don't do this. 
See lldb/examples/python/sbvalue.py .

Also is something like
```
        result.PutCString(
            "warning: {} returned non-zero value {}".format(
                filter_program, proc.returncode
            )
        )
```
really better than
```
        result.PutCString("warning: {} returned non-zero value 
{}".format(filter_program, proc.returncode))
```
?

https://github.com/llvm/llvm-project/pull/145793
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to