eugene added inline comments.

================
Comment at: include/lldb/Target/Process.h:3148
 
+  virtual Error UpdateAutomaticSignalFiltering();
+
----------------
clayborg wrote:
> Can we remove this and only have it in ProcessGDBRemote? Then we just call it 
> when we need to in ProcessGDBRemote? This seems like something that 
> ProcessGDBRemote should take care of without having Process knowing about it. 
> Seems like a adding a call to 
> ProcessGDBRemote::UpdateAutomaticSignalFiltering() can be done in 
> ProcessGDBRemote::WillResume() and ProcessGDBRemote::DidLaunch() might do the 
> trick? It seems like each process plug-in will have different needs regarding 
> signals.
I 100% agree with you here. UpdateAutomaticSignalFiltering() is very much 
implementation specific and it shouldn't be in the  lldb_private::Process.  And 
it was how I originally implemented it in older revision. 

But Jim felt differently and I trusted his judgement given that he has vastly 
more experience working with LLDB codebase.




https://reviews.llvm.org/D30520



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to