eugene added a comment.

UnixSignals is a nice self contained class that already does 99% of the work 
(see UnixSignals::GetFilteredSignals). I don't think we should have it call 
anybody. 
Only process knows when it is the right time to send actual QPassSignals 
packet, there is not need to somehow push this knowledge into UnixSignals.

Let's just decide if UpdateAutomaticSignalFiltering() is specific enough to 
live in GDBProcess or it's generic enough to live in the base process. I'm fine 
either way.


https://reviews.llvm.org/D30520



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to