beanz added a comment.

Please revert your patch. It is *not* the right solution and is masking 
underlying problems.

ExecutionEngine headers directly reference symbols from RuntimeDyld, so we 
should enforce a requirement that anyone using ExeuctionEngine also link 
RuntimeDyld. This works today as expected for static archive builds. It is only 
broken with `BUILD_SHARED_LIBS`. I suspect the problem is that when built as a 
DSO ExecutionEngine has no unresolved symbols against RuntimeDyld, and the 
linker probably isn't including the reference to RuntimeDyld in the produced 
ExecutionEngine DSO.

Regardless of the underlying cause, this is not the correct solution, it merely 
hides a problem that could occur in other consumers of ExecutionEngine.


Repository:
  rL LLVM

https://reviews.llvm.org/D31367



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to