On czw, 2017-03-30 at 13:55 -0700, Chris Bieneman wrote:
> I had a talk with Lang about the ExecutionEngine library structuring, and it
> sounds like there are some problems there that need to be worked out.
>
> Luckily for this specific case, I think the solution is actually quite simple:
>
> ```
> diff --git a/include/llvm/ExecutionEngine/ExecutionEngine.h
> b/include/llvm/ExecutionEngine/ExecutionEngine.h
> index f68337c..cc99f94 100644
> --- a/include/llvm/ExecutionEngine/ExecutionEngine.h
> +++ b/include/llvm/ExecutionEngine/ExecutionEngine.h
> @@ -15,7 +15,6 @@
> #ifndef LLVM_EXECUTIONENGINE_EXECUTIONENGINE_H
> #define LLVM_EXECUTIONENGINE_EXECUTIONENGINE_H
>
> -#include "RuntimeDyld.h"
> #include "llvm-c/ExecutionEngine.h"
> #include "llvm/ADT/SmallVector.h"
> #include "llvm/ADT/StringRef.h"
> @@ -49,6 +48,7 @@ class ObjectCache;
> class RTDyldMemoryManager;
> class Triple;
> class Type;
> +class JITSymbolResolver;
>
> namespace object {
> class Archive;
> ```
>
> It seems to me that there is no reason why ExecutionEngine.h needs to include
> RuntimeDyld.h. a forward declaration of the JITSymbolResolver class will
> suffice.
> Thanks, I'll test this patch and get back to you. -- Best regards, Michał Górny
signature.asc
Description: This is a digitally signed message part
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
