================
@@ -283,7 +283,7 @@ ModuleSP DynamicLoader::LoadBinaryWithUUIDAndAddress(
// If we haven't found a binary, or we don't have a SymbolFile, see
// if there is an external search tool that can find it.
- if (!module_sp || !module_sp->GetSymbolFileFileSpec()) {
+ if (!module_sp || !module_sp->GetSymbolFile(/*can_create=*/true)) {
----------------
JDevlieghere wrote:
This tests "was a symbol vendor created" but that doesn't necessary imply we
have debug info. AFAIK this returns a non-null SymbolFileSymtab for any binary
with a symbol table. I think we should check the symbol's file abilities (e.g.
CompileUnits/LineTables) here.
It also looks like this returns `nullptr` when someone raises the interrupt
mechanism. So we're going to start calling DownloadObjectAndSymbolFile and
probably make things take even longer especially for the operation the user
wanted to interrupt.
https://github.com/llvm/llvm-project/pull/210206
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
