This looks beautiful indeed. The problem is that it doesn't quite work with the current MemoryBuffer and the line_iterator : for one thing there's no way to construct a MemoryBuffer from a StringRef, or to use the line_iterator directly with a StringRef.
On Tue, Sep 19, 2017 at 10:39 AM, Zachary Turner via Phabricator < revi...@reviews.llvm.org> wrote: > zturner added a comment. > > Give me a few more hours, if there's a way to make this work with > `line_iterator` I'd really prefer that since I think it improves > readability. Can you confirm that if you were able to write: > > auto begin = line_iterator(str, /* skip_empty_lines =*/ false); > auto end = line_iterator(); > while (begin != end && !WasInterrupted()) { > stream.Write(*begin); > if (++begin != end) > stream.Write("\n"); > } > > That this would be equivalent? > > > https://reviews.llvm.org/D37923 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits