Hi Greg, are you referring to the manual line splitting vs. using StringRef::split()? This is how it's documented:
/// Split into two substrings around the first occurrence of a separator /// character. /// /// If \p Separator is in the string, then the result is a pair (LHS, RHS) /// such that (*this == LHS + Separator + RHS) is true and RHS is /// maximal. If \p Separator is not in the string, then the result is a /// pair (LHS, RHS) where (*this == LHS) and (RHS == ""). Yes, RHS == "" happens to be be implemented as a StringRef with nullptr data, but this seems to make the implementation even more depended on the subtle details. My point was that second == "" in two cases: separator is not in the string AND separator is _last_ character in the string. Did I get the question right? On Mon, Sep 18, 2017 at 3:51 PM, Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > ok. Then back to the "can we use StringRef"? We might be able to check if > the second.data() is NULL? It might be NULL if the string doesn't end with > a newline. It it does, it might be empty but contain a pointer to the '\0' > byte? > > > https://reviews.llvm.org/D37923 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
