gut added a comment. Thanks for supporting this change. I guess @anajuliapc will add you both as reviewer as soon as she updates this patch.
BTW, I agree that patches should be improving code quality but I wanted to highlight that these changes were actually based on the current ARM64 implementation. E.g: this snip <https://github.com/llvm-mirror/lldb/blob/master/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp#L609> and this requested change <https://reviews.llvm.org/D38897#inline-339476>. But thanks for pointing it out. ================ Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.h:98-99 + uint32_t refcount; // Serves as enable/disable and reference counter. + long slot; // Saves the value returned from PTRACE_SETHWDEBUG. + int mode; // Defines if watchpoint is read/write/access. + }; ---------------- clayborg wrote: > As long as this code is only ever compiled native, using "long" and "int" are > ok. Just beware of code that isn't always compiled native. It's a native only compiled file (see line 13. It defines a `#if defined(__powerpc64__)` that ends at the end of file) https://reviews.llvm.org/D38897 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
