zturner added a comment. In https://reviews.llvm.org/D38897#897378, @gut wrote:
> Thanks for supporting this change. I guess @anajuliapc will add you both as > reviewer as soon as she updates this patch. > > BTW, I agree that patches should be improving code quality but I wanted to > highlight that these changes were actually based on the current ARM64 > implementation. E.g: this snip > <https://github.com/llvm-mirror/lldb/blob/master/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp#L609> > and this requested change <https://reviews.llvm.org/D38897#inline-339476>. > But thanks for pointing it out. I'd be equally fine with extracting that logic into a separate function, it looks mostly the same? I don't think we should be duplicating code (or even algorithms written slightly differently) https://reviews.llvm.org/D38897 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
