labath added a comment.
The patch looks fine to me. I think I'd make the arm test (I guess that is
interesting because of the bit 0 twiddling ?) a non-execution test, but this is
fine as well.
================
Comment at:
packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/TestBreakpointThumbCodesection.py:29
+
+ self.runCmd("run")
+
----------------
Do you think there's any added value in making sure that the breakpoint is
*hit* (instead of just making sure that it's resolved to the right file
address). If it's the latter we could make this a non-execution test and have
it run everywhere (e.g., via lldb-test breakpoint) instead of just on arm
hardware.
https://reviews.llvm.org/D44998
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
