clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.
================
Comment at: source/Core/Section.cpp:30
-static const char *GetSectionTypeAsCString(lldb::SectionType sect_type) {
+const char *Section::GetSectionTypeAsCString(lldb::SectionType sect_type) {
switch (sect_type) {
----------------
davide wrote:
> kbaladurin wrote:
> > clayborg wrote:
> > > Why did you take static off of this function? Please remove this change,
> > > or change this function to get the section type from the section itself
> > > and not require the argument.
> > I change it to static method to use it in `lldb-test`. There is similar
> > static methods in `Value` and `Scalar` classes:
> > `Value::GetValueTypeAsCString` and `Scalar::GetValueTypeAsCString`. Is non
> > static method more preferable for us in this case?
> I think what you did was correct. Greg?
Woops, I missed the extra "Section::" that was added. You indeed did do this
right... I thought in my mind that the "Section::" was there prior to this
change and we were making the function a member function. My bad.
https://reviews.llvm.org/D44998
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
