labath added a comment.

Hmm.. I think I've thought of (or remembered, because I have been thinking 
about Utility too) a reason why it might be better to keep these in Host. 
ProcessLaunchInfo cannot be trivially moved to Utility (and indeed, in this 
patch, you are keeping it in Host), because it contains some references to 
Host-specific code (PTY stuff). Now, I am not convinced having the PTY class be 
a member of ProcessLaunchInfo is a good thing, but assuming we don't want to 
refactor that now, I think it might be better to keep Process(Launch)Info and 
friends in the same package (i.e., in Host), at least until we have a reason to 
do otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58842/new/

https://reviews.llvm.org/D58842



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to