apaprocki added inline comments.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) + log->Printf("sorry: unimplemented for XCOFF"); + return false; ---------------- No need to be `sorry:` :) This should probably just say `error: XCOFF is unimplemented` to be more direct in case anything is expecting "error:" in the output. ================ Comment at: llvm/lib/Support/Triple.cpp:537 return StringSwitch<Triple::ObjectFormatType>(EnvironmentName) + // FIXME: We have to put XCOFF before COFF; + // perhaps an order-independent pattern matching is desired? ---------------- hubert.reinterpretcast wrote: > If the conclusion is that checking XCOFF before COFF is fine, then we should > remove the FIXME and just leave a normal comment. Agreed, existing code seems fine as long as there is a comment explaining that `xcoff` must come before `coff` in case it isn't obvious at a quick glance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits